Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base image hash (#4871) #4917

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Base image hash (#4871) #4917

merged 1 commit into from
Jan 15, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 15, 2024

add docker image sha to dockerfile

Proposed changes

Cherry pick docker pin image hash to release-3.4 branch to address security issues

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

add docker image sha to dockerfile
@pdabelf5 pdabelf5 requested a review from a team as a code owner January 15, 2024 11:45
@github-actions github-actions bot added the tests Pull requests that update tests label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a376068) 52.10% compared to head (44fbb12) 52.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.4    #4917   +/-   ##
============================================
  Coverage        52.10%   52.10%           
============================================
  Files               60       60           
  Lines            17368    17368           
============================================
  Hits              9050     9050           
  Misses            8002     8002           
  Partials           316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 6c395cf into release-3.4 Jan 15, 2024
69 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-docker-hash branch January 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants