Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCR AWS plus publish fix #4934

Merged
merged 1 commit into from
Jan 16, 2024
Merged

GCR AWS plus publish fix #4934

merged 1 commit into from
Jan 16, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 16, 2024

Proposed changes

GCR AWS plus publish fix

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 16, 2024 14:38
@danielnginx danielnginx requested a review from a team January 16, 2024 14:39
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19706a7) 52.13% compared to head (2d25968) 52.13%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.4    #4934   +/-   ##
============================================
  Coverage        52.13%   52.13%           
============================================
  Files               60       60           
  Lines            17368    17368           
============================================
  Hits              9054     9054           
  Misses            8000     8000           
  Partials           314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) January 16, 2024 14:42
@pdabelf5 pdabelf5 merged commit 3990129 into release-3.4 Jan 16, 2024
15 checks passed
@pdabelf5 pdabelf5 deleted the gcr-aws-plus-fix branch January 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants