Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community page for NIC #5038

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Add community page for NIC #5038

merged 3 commits into from
Feb 6, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Feb 6, 2024

Proposed changes

Based on the nginx-agent community page.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested review from a team as code owners February 6, 2024 10:54
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Feb 6, 2024
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Signed-off-by: oseoin <oseoin@users.noreply.github.com>
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to put this document in its own section? It can be a standalone page.

As convention, we avoid creating entire sections for single documents.

We similarly avoid preemptively adding a section in anticipation of more content, as it's the information architecture equivalent of premature optimisation.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the IA feedback.

@oseoin oseoin enabled auto-merge (squash) February 6, 2024 11:28
@oseoin oseoin merged commit 3839c16 into main Feb 6, 2024
49 of 52 checks passed
@oseoin oseoin deleted the contribute-page branch February 6, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants