Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick: Fix template file spacing for ssl_protocols directive (#5020) #5060

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

j1m-ryan
Copy link
Member

@j1m-ryan j1m-ryan commented Feb 9, 2024

Cherry pick for ssl protocols spacing

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner February 9, 2024 10:47
@j1m-ryan j1m-ryan changed the title Fix template file spacing for ssl_protocols directive (#5020) cherry pick: Fix template file spacing for ssl_protocols directive (#5020) Feb 9, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) February 9, 2024 10:48
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (760d891) 52.13% compared to head (7c342eb) 52.13%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.4    #5060   +/-   ##
============================================
  Coverage        52.13%   52.13%           
============================================
  Files               60       60           
  Lines            17368    17368           
============================================
  Hits              9054     9054           
  Misses            8000     8000           
  Partials           314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Feb 9, 2024

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7c342eb

@j1m-ryan j1m-ryan merged commit 203cb6e into nginxinc:release-3.4 Feb 9, 2024
58 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants