Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm notes cherry pick #5071

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Helm notes cherry pick #5071

merged 1 commit into from
Feb 12, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Feb 12, 2024

  • add docs links to helm NOTES.txt

Proposed changes

Cherry pick of: #4953

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

* add docs links to helm NOTES.txt
@oseoin oseoin requested review from a team as code owners February 12, 2024 15:20
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a1807e) 52.13% compared to head (90bdf1c) 52.10%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.4    #5071      +/-   ##
===============================================
- Coverage        52.13%   52.10%   -0.03%     
===============================================
  Files               60       60              
  Lines            17368    17368              
===============================================
- Hits              9054     9050       -4     
- Misses            8000     8002       +2     
- Partials           314      316       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oseoin oseoin merged commit 8acba14 into release-3.4 Feb 12, 2024
69 checks passed
@oseoin oseoin deleted the helm-notes-cherry-pick branch February 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants