Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default values for keepalive-requests and keepalive-timeout #5083

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

This change updates the default values for keepalive-requests and keepalive-timeout to be consistant with the default values used by NGINX. Docs updated to reflect these changes.

Resolves : #5050

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners February 13, 2024 15:47
Copy link

netlify bot commented Feb 13, 2024

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3c13977

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Feb 13, 2024
Copy link
Member

@j1m-ryan j1m-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pdabelf5 pdabelf5 mentioned this pull request Feb 14, 2024
6 tasks
@shaun-nx shaun-nx merged commit 6406747 into nginxinc:main Feb 14, 2024
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Increase keepalive-requests from 100 to 1000, the nginx default
6 participants