Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Prometheus variable labels (#5008) #5085

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

haywoodsh
Copy link
Contributor

Remove redundant variable labels

Signed-off-by: Haywood Shannon 5781935+haywoodsh@users.noreply.github.com
(cherry picked from commit fb60fb6)

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Remove redundant variable labels

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
(cherry picked from commit fb60fb6)
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (997981f) 52.16% compared to head (c0dc07c) 52.18%.

Files Patch % Lines
cmd/nginx-ingress/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.4    #5085      +/-   ##
===============================================
+ Coverage        52.16%   52.18%   +0.01%     
===============================================
  Files               60       60              
  Lines            17368    17366       -2     
===============================================
+ Hits              9060     9062       +2     
+ Misses            7994     7990       -4     
  Partials           314      314              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haywoodsh haywoodsh marked this pull request as ready for review February 13, 2024 16:37
@haywoodsh haywoodsh requested a review from a team as a code owner February 13, 2024 16:37
@pdabelf5 pdabelf5 merged commit 0f45ece into release-3.4 Feb 13, 2024
69 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-prometheus-variable-label branch February 13, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants