-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect count of VirtualServer, VirtualServerRoute and TransportServer resources #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaun <s.odonovan@f5.com>
jjngx
reviewed
Feb 16, 2024
jjngx
reviewed
Feb 16, 2024
jjngx
reviewed
Feb 16, 2024
jjngx
reviewed
Feb 16, 2024
jjngx
reviewed
Feb 16, 2024
jjngx
reviewed
Feb 16, 2024
jjngx
reviewed
Feb 16, 2024
jjngx
reviewed
Feb 20, 2024
vepatel
approved these changes
Feb 20, 2024
jjngx
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change updates the base telemetry job to collect a count of VirtualServer and TransportServer resources that are observed by the Ingress Controller.
Closes #4902 and #4903
Testing
Test cases in
collector.go
cover scenarios where:Additional changes
Renamed
telemetry.go
tocollector.go
Moved code related to the
DiscardExporter
out ofcollector.go
and intoexporter.go
Note: Tests in
collector_test.go
cover calls to the Export function inexporter.go
Checklist
Before creating a PR, run through this checklist and mark each as complete.