Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeCount to telemetry data #5147

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Add NodeCount to telemetry data #5147

merged 4 commits into from
Feb 22, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Feb 21, 2024

Proposed changes

This PR adds the k8s node counting functionality for the telemetry data collector.

Log example after deployment to a local kind cluster with one node:

I0221 17:08:04.753632       1 collector.go:81] Collecting telemetry data
I0221 17:08:04.779743       1 collector.go:91] Exported telemetry data: {ProjectMeta:{Name: Version:} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:1}

Log example after deployment to a local kind cluster with three nodes:

I0221 17:15:05.111857       1 collector.go:81] Collecting telemetry data
I0221 17:15:05.130732       1 collector.go:91] Exported telemetry data: {ProjectMeta:{Name: Version:} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:3}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Feb 21, 2024
@jjngx jjngx marked this pull request as ready for review February 21, 2024 17:16
@jjngx jjngx requested a review from a team as a code owner February 21, 2024 17:16
@jjngx jjngx linked an issue Feb 21, 2024 that may be closed by this pull request
@jjngx jjngx merged commit b4114ba into main Feb 22, 2024
77 checks passed
@jjngx jjngx deleted the feat/telemetry-node-count branch February 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect Node Count in Cluster
3 participants