Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterID to telemetry data #5155

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Add ClusterID to telemetry data #5155

merged 3 commits into from
Feb 23, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Feb 22, 2024

Proposed changes

This PR adds functionality to collect K8s ClusterID and add it to the telemetry data.

Logs:

I0222 12:24:10.058225       1 collector.go:81] Collecting telemetry data
I0222 12:24:10.079962       1 collector.go:90] Exported telemetry data: {ProjectMeta:{Name: Version:} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:1 ClusterID:bac905ad-d17b-4a94-b081-798c2373a7e2}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner February 22, 2024 12:33
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Feb 22, 2024
@jjngx jjngx linked an issue Feb 22, 2024 that may be closed by this pull request
internal/telemetry/cluster_test.go Outdated Show resolved Hide resolved
internal/telemetry/cluster_test.go Show resolved Hide resolved
internal/telemetry/cluster_test.go Show resolved Hide resolved
@jjngx jjngx merged commit 19671a5 into main Feb 23, 2024
80 checks passed
@jjngx jjngx deleted the feat/telemetry-cluster-id branch February 23, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect the Cluster ID
4 participants