Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update external-dns version #5166

Merged
merged 3 commits into from
Feb 27, 2024
Merged

update external-dns version #5166

merged 3 commits into from
Feb 27, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Feb 26, 2024 •
edited

Proposed changes

  • update external-dns version in example and tests yaml

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner February 26, 2024 15:28
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Feb 26, 2024
@vepatel vepatel enabled auto-merge (squash) February 26, 2024 17:01
@vepatel vepatel merged commit cdd2542 into main Feb 27, 2024
28 of 29 checks passed
@vepatel vepatel deleted the chore/update-external-dns branch February 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vepatel @oseoin @j1m-ryan @jjngx @pdabelf5