Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K8s version and ARCH to telemetry data #5170

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Feb 26, 2024

Proposed changes

This PR adds support for collecting K8s version and Arch for telemetry.

Example NIC log:

I0227 06:42:14.983453       1 collector.go:82] Collecting telemetry data
I0227 06:42:15.004683       1 collector.go:91] Exported telemetry data: {ProjectMeta:{Name: Version:} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:1 ClusterID:c232007d-76bf-48a5-8dc2-60e017467f0f K8sVersion:v1.29.2 Arch:amd64}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner February 26, 2024 20:07
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Feb 26, 2024
@jjngx jjngx linked an issue Feb 26, 2024 that may be closed by this pull request
@jjngx jjngx changed the title Add K8s version to telemetry data Add K8s version and ARCH to telemetry data Feb 27, 2024
@jjngx jjngx linked an issue Feb 27, 2024 that may be closed by this pull request
@jjngx jjngx merged commit 5ec3fcd into main Feb 27, 2024
81 checks passed
@jjngx jjngx deleted the feat/telemetry-k8s-version branch February 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect architecture - x86, ARM, s390, unknown other Collect version of k8s
3 participants