Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NIC metadata (name and version) to telemetry data #5176

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Feb 27, 2024

Proposed changes

This PR adds NIC metadata (Name, Version) to telemetry.

NIC log example:

I0227 16:58:42.719659       1 collector.go:85] Collecting telemetry data
I0227 16:58:42.746579       1 collector.go:94] Exported telemetry data: {ProjectMeta:{Name:NIC Version:3.5.0-SNAPSHOT} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:1 ClusterID:c232007d-76bf-48a5-8dc2-60e017467f0f K8sVersion:v1.29.2 Arch:amd64}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner February 27, 2024 17:03
@jjngx jjngx linked an issue Feb 27, 2024 that may be closed by this pull request
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Feb 27, 2024
@jjngx jjngx merged commit 2b02d07 into main Feb 28, 2024
83 checks passed
@jjngx jjngx deleted the feat/telemetry-nic-metadata branch February 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect version and name of project
4 participants