Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move common pod label definitions to helpers #5179

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Move common pod label definitions to helpers #5179

merged 2 commits into from
Feb 28, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Feb 28, 2024

Proposed changes

Move common pod labels to new helper.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested a review from a team as a code owner February 28, 2024 11:52
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Feb 28, 2024
@oseoin oseoin enabled auto-merge (squash) February 28, 2024 12:50
@oseoin oseoin merged commit 630c19e into main Feb 28, 2024
54 checks passed
@oseoin oseoin deleted the helm-label-refactor branch February 28, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oseoin @j1m-ryan @vepatel @jjngx @pdabelf5