-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent management and helm configuration #5188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I have many grammar/phrasing suggestions.
We never just say "Ingress Controller", because that could apply to anything in the ecosystem. Within the context of the software or a singular example, we write just "NGINX Ingress Controller", no prefix with the.
Documentation is meant to be imperative and instructional: there should be no uncertainty, so we avoid words like "try", "should", etc. We also avoid a familiar tone where possible, so minimise usage of "we".
docs/content/installation/installing-nic/installation-with-helm.md
Outdated
Show resolved
Hide resolved
docs/content/installation/installing-nic/installation-with-helm.md
Outdated
Show resolved
Hide resolved
docs/content/installation/installing-nic/installation-with-helm.md
Outdated
Show resolved
Hide resolved
docs/content/installation/installing-nic/installation-with-helm.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Dooley <a.dooley@f5.com> Signed-off-by: oseoin <oseoin@users.noreply.github.com>
Proposed changes
Adds management of the NGINX Agent process along with Helm configuration for the Agent process.
Checklist
Before creating a PR, run through this checklist and mark each as complete.