Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent management and helm configuration #5188

Merged
merged 32 commits into from
Mar 13, 2024
Merged

Agent management and helm configuration #5188

merged 32 commits into from
Mar 13, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Feb 29, 2024

Proposed changes

Adds management of the NGINX Agent process along with Helm configuration for the Agent process.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Feb 29, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 8, 2024
@oseoin oseoin marked this pull request as ready for review March 8, 2024 12:12
@oseoin oseoin requested a review from a team as a code owner March 8, 2024 12:12
@oseoin oseoin requested a review from a team as a code owner March 8, 2024 12:21
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I have many grammar/phrasing suggestions.

We never just say "Ingress Controller", because that could apply to anything in the ecosystem. Within the context of the software or a singular example, we write just "NGINX Ingress Controller", no prefix with the.

Documentation is meant to be imperative and instructional: there should be no uncertainty, so we avoid words like "try", "should", etc. We also avoid a familiar tone where possible, so minimise usage of "we".

charts/nginx-ingress/README.md Outdated Show resolved Hide resolved
examples/ingress-resources/security-monitoring/README.md Outdated Show resolved Hide resolved
examples/ingress-resources/security-monitoring/README.md Outdated Show resolved Hide resolved
examples/ingress-resources/security-monitoring/README.md Outdated Show resolved Hide resolved
examples/ingress-resources/security-monitoring/README.md Outdated Show resolved Hide resolved
examples/ingress-resources/security-monitoring/README.md Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
@oseoin oseoin linked an issue Mar 13, 2024 that may be closed by this pull request
@oseoin oseoin enabled auto-merge (squash) March 13, 2024 12:13
@oseoin oseoin merged commit 0f77019 into main Mar 13, 2024
49 checks passed
@oseoin oseoin deleted the agent-management branch March 13, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Configure NAP Security Monitoring output to Agent
6 participants