Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zone size for transportserver resource #5199

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Update zone size for transportserver resource #5199

merged 3 commits into from
Mar 5, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Mar 5, 2024 •
edited

Proposed changes

This change updates the zone size value within transportserver. By increasing the value we ensure enough memory is allocated and the zone does not run out of memory.

Resolves: #5191

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner March 5, 2024 14:22
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Mar 5, 2024
j1m-ryan
j1m-ryan approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@j1m-ryan j1m-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jjngx
jjngx approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

shaun-nx
shaun-nx approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@AlexFenlon AlexFenlon self-assigned this Mar 5, 2024
@AlexFenlon AlexFenlon merged commit 5231bac into main Mar 5, 2024
77 checks passed
@AlexFenlon AlexFenlon deleted the feat/transportserver-zone-size branch March 5, 2024 15:09
AlexFenlon added a commit that referenced this pull request Mar 5, 2024
@AlexFenlon
Revert "Update zone size for transportserver resource (#5199)"
06cc939 
This reverts commit 5231bac.
@AlexFenlon AlexFenlon mentioned this pull request Mar 5, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees

@AlexFenlon AlexFenlon

Labels
enhancement Pull requests for new features/feature enhancements
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase zone size for transportserver from 256k to 512k
6 participants
@AlexFenlon @j1m-ryan @vepatel @jjngx @shaun-nx @pdabelf5