Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prometheus port annotation to string #520

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Mar 25, 2019

Proposed changes

Fixed a bug on daemon-set/deployment manifests when using the prometheus.io/port annotation for NGINX and NGINX Plus. Port needs to be a string and it was incorrectly set as an int.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox added the bug An issue reporting a potential bug label Mar 25, 2019
@Rulox Rulox self-assigned this Mar 25, 2019
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit 4d0ffc2 into master Mar 26, 2019
@Rulox Rulox deleted the fix-prometheus-port branch March 26, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants