Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve valid listeners when invalid listeners are present in GlobalConfiguration #5205

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Preserve valid listeners when invalid listeners are present in GlobalConfiguration #5205

merged 9 commits into from
Apr 15, 2024

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Mar 6, 2024 •
edited

Proposed changes

Improve validation process for the GlobalConfiguration. The updated logic will allow the application of a GlobalConfiguration resource even if it includes invalid listeners. Invalid listeners will be disregarded while the valid ones will remain, which ensures valid VS and TS configs are operational and continue to accept traffics. NIC will emit a Warning Kubernetes event for the GlobalConfiguration with the reason AddedOrUpdatedWithError for any invalid listeners.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests labels Mar 6, 2024
@haywoodsh haywoodsh force-pushed the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch 9 times, most recently from 56c812c to a9e5c83 Compare April 2, 2024 15:49
@haywoodsh haywoodsh force-pushed the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch 3 times, most recently from 8f5bb22 to 004062d Compare April 4, 2024 13:04
@haywoodsh haywoodsh linked an issue Apr 5, 2024 that may be closed by this pull request
NIC removes all listeners when rejecting a new one on a reserved port #4775
Closed
@haywoodsh haywoodsh changed the title allow global configuration with invalid listeners to be applied with warnings Preserve valid listeners when invalid listeners are present in GlobalConfiguration Apr 5, 2024
@haywoodsh haywoodsh force-pushed the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch from 4b305cd to 02e6d38 Compare April 5, 2024 17:12
@haywoodsh haywoodsh marked this pull request as ready for review April 5, 2024 17:16
@haywoodsh haywoodsh requested review from a team as code owners April 5, 2024 17:16
@brianehlert brianehlert added this to the v3.6.0 milestone Apr 8, 2024
@haywoodsh haywoodsh force-pushed the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch 2 times, most recently from 0b94315 to f7583a8 Compare April 9, 2024 13:45
@haywoodsh haywoodsh force-pushed the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch 3 times, most recently from b85f2b4 to 0a8c4b1 Compare April 11, 2024 16:44
@haywoodsh haywoodsh force-pushed the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch 4 times, most recently from ae56334 to 859a6bf Compare April 15, 2024 09:07
haywoodsh and others added 9 commits April 15, 2024 13:39
@haywoodsh
add reason with error for gc
91583fe 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
add unit tests and python tests
2a3edcc 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
add python tests
1b943c7 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@pre-commit-ci @haywoodsh
[pre-commit.ci] auto fixes from pre-commit.com hooks
b065ee1 
for more information, see https://pre-commit.ci
@haywoodsh
update unit tests
f068775 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
use cmp.diff
4634e91 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
update docs
ba08f0d 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
remove redundant logging and methods, rename tests
dfc030e 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh
rename error reason to AddedOrUpdatedWithError
eafd20f 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh force-pushed the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch from 859a6bf to eafd20f Compare April 15, 2024 12:39
@haywoodsh haywoodsh enabled auto-merge (squash) April 15, 2024 13:16
@haywoodsh haywoodsh merged commit 0f64f04 into main Apr 15, 2024
53 checks passed
@haywoodsh haywoodsh deleted the feat/allow-valid-listeners-for-gc-with-errorgc-with-errors branch April 15, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

NIC removes all listeners when rejecting a new one on a reserved port
4 participants
@haywoodsh @jjngx @shaun-nx @brianehlert