-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve valid listeners when invalid listeners are present in GlobalConfiguration #5205
Merged
haywoodsh
merged 9 commits into
main
from
feat/allow-valid-listeners-for-gc-with-errorgc-with-errors
Apr 15, 2024
Merged
Preserve valid listeners when invalid listeners are present in GlobalConfiguration #5205
haywoodsh
merged 9 commits into
main
from
feat/allow-valid-listeners-for-gc-with-errorgc-with-errors
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56c812c
to
a9e5c83
Compare
8f5bb22
to
004062d
Compare
4b305cd
to
02e6d38
Compare
0b94315
to
f7583a8
Compare
jjngx
approved these changes
Apr 9, 2024
shaun-nx
reviewed
Apr 10, 2024
docs/content/configuration/global-configuration/globalconfiguration-resource.md
Show resolved
Hide resolved
b85f2b4
to
0a8c4b1
Compare
shaun-nx
approved these changes
Apr 12, 2024
ae56334
to
859a6bf
Compare
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
859a6bf
to
eafd20f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
tests
Pull requests that update tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improve validation process for the GlobalConfiguration. The updated logic will allow the application of a GlobalConfiguration resource even if it includes invalid listeners. Invalid listeners will be disregarded while the valid ones will remain, which ensures valid VS and TS configs are operational and continue to accept traffics. NIC will emit a
Warning
Kubernetes event for the GlobalConfiguration with the reasonAddedOrUpdatedWithError
for any invalid listeners.Checklist
Before creating a PR, run through this checklist and mark each as complete.