Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics logic to perf tests #5224

Merged
merged 3 commits into from
Mar 11, 2024
Merged

add metrics logic to perf tests #5224

merged 3 commits into from
Mar 11, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Mar 8, 2024

Proposed changes

Adds pod and node metrics logic to perf tests.

[
    {
        "metadata": {
            "name": "nginx-ingress-7d74b6b9fc-jj9mz",
            "namespace": "nginx-ingress",
            "creationTimestamp": "2024-03-08T14:18:27Z",
            "labels": {
                "app": "nginx-ingress",
                "app.kubernetes.io/name": "nginx-ingress",
                "app.kubernetes.io/version": "3.5.0",
                "app.nginx.org/version": "1.25.4",
                "pod-template-hash": "7d74b6b9fc"
            }
        },
        "timestamp": "2024-03-08T14:18:19Z",
        "window": "24.379s",
        "containers": [
            {
                "name": "nginx-ingress",
                "usage": {
                    "cpu": "74155994n",
                    "memory": "19628Ki"
                }
            }
        ]
    }
]
[
    {
        "metadata": {
            "name": "gke-venktesh-test-default-pool-80cf31c5-5rx7",
            "creationTimestamp": "2024-03-08T14:18:27Z",
        },
        "timestamp": "2024-03-08T14:18:16Z",
        "window": "30.169s",
        "usage": {
            "cpu": "404319897n",
            "memory": "1189960Ki"
        }
    }
]

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner March 8, 2024 14:25
@vepatel vepatel linked an issue Mar 8, 2024 that may be closed by this pull request
@github-actions github-actions bot added the tests Pull requests that update tests label Mar 8, 2024
@vepatel vepatel enabled auto-merge (squash) March 11, 2024 11:51
@vepatel vepatel merged commit ca0c643 into main Mar 11, 2024
49 checks passed
@vepatel vepatel deleted the tests/add-resource-usage branch March 11, 2024 12:06
pdabelf5 pushed a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add node and pod resource usage to NIC tests
3 participants