Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstallationID to telemetry data #5256

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Add InstallationID to telemetry data #5256

merged 4 commits into from
Mar 15, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 15, 2024

Proposed changes

This PR adds InstallationID to Telemetry Data

Logs for:

  • Deployment/ReplicaSet
I0315 11:37:20.178752       1 collector.go:91] Collecting telemetry data
I0315 11:37:20.223375       1 collector.go:120] Exported telemetry data: {Data:{ProjectName:NIC ProjectVersion:3.5.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:559913af-b619-4cc6-b253-ff5934e0d665 ClusterVersion:v1.29.2 ClusterPlatform:kind InstallationID:b56aa23c67aa92bca81d25b6cb7139b3 ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0 Replicas:1}}

I0315 11:37:25.294401       1 collector.go:91] Collecting telemetry data
I0315 11:37:25.336820       1 collector.go:120] Exported telemetry data: {Data:{ProjectName:NIC ProjectVersion:3.5.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:559913af-b619-4cc6-b253-ff5934e0d665 ClusterVersion:v1.29.2 ClusterPlatform:kind InstallationID:b56aa23c67aa92bca81d25b6cb7139b3 ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0 Replicas:3}}
  • DaemonSet
I0315 11:39:59.602766       1 collector.go:91] Collecting telemetry data
I0315 11:39:59.629229       1 collector.go:120] Exported telemetry data: {Data:{ProjectName:NIC ProjectVersion:3.5.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:559913af-b619-4cc6-b253-ff5934e0d665 ClusterVersion:v1.29.2 ClusterPlatform:kind InstallationID:15e7a628a0c11339b7e312d28ffe5fe2 ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0 Replicas:1}}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner March 15, 2024 11:52
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Mar 15, 2024
@jjngx jjngx linked an issue Mar 15, 2024 that may be closed by this pull request
@jjngx
Copy link
Contributor Author

jjngx commented Mar 15, 2024

Updated the way how the InstallationID is reported.

Logs

DaemonSet:

I0315 15:03:55.063779       1 collector.go:91] Collecting telemetry data
I0315 15:03:56.108280       1 collector.go:120] Telemetry data collected: {Data:{ProjectName:NIC ProjectVersion:3.5.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:559913af-b619-4cc6-b253-ff5934e0d665 ClusterVersi
on:v1.29.2 ClusterPlatform:kind InstallationID:3f9f4b08-6b1f-4511-906d-4538884c5542 ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0 Replicas:1}}

ReplicaSet:

I0315 15:05:30.945385       1 collector.go:91] Collecting telemetry data
I0315 15:05:31.378672       1 collector.go:120] Telemetry data collected: {Data:{ProjectName:NIC ProjectVersion:3.5.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:559913af-b619-4cc6-b253-ff5934e0d665 ClusterVersi
on:v1.29.2 ClusterPlatform:kind InstallationID:83a55cf8-2260-436d-ac8b-611d44f5cd41 ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0 Replicas:1}}

@jjngx jjngx merged commit 2ac4ae6 into main Mar 15, 2024
77 checks passed
@jjngx jjngx deleted the feat/tel-installation-id branch March 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect the InstallationID
3 participants