Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for apLogBundle in WAF policy #5259

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Add support for apLogBundle in WAF policy #5259

merged 11 commits into from
Mar 15, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Mar 15, 2024

Proposed changes

Add apLogBundle field to securityLogs to support compiled log configurations. Mutually exclusive with apLogConf

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 15, 2024
@oseoin oseoin marked this pull request as ready for review March 15, 2024 15:32
@oseoin oseoin requested review from a team as code owners March 15, 2024 15:32
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the docs side but the links should be changed.

…ration.md

Co-authored-by: Alan Dooley <a.dooley@f5.com>
Signed-off-by: oseoin <oseoin@users.noreply.github.com>
@oseoin oseoin linked an issue Mar 15, 2024 that may be closed by this pull request
@oseoin oseoin enabled auto-merge (squash) March 15, 2024 16:57
@oseoin oseoin merged commit 323cce7 into main Mar 15, 2024
49 checks passed
@oseoin oseoin deleted the log-bundle-support branch March 15, 2024 17:14
@@ -228,6 +228,24 @@ spec:
apBundle: "<policy_bundle_name>.tgz"
```

This example shows the same policy as above but with a log bundle used for :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oseoin - is there a missing word here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how I missed this, thanks @jputrino! Fixed in #5269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

NAP Bundle support for NIC Security Monitoring
6 participants