Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct helm version in docs #5287

Merged
merged 2 commits into from
Mar 21, 2024
Merged

correct helm version in docs #5287

merged 2 commits into from
Mar 21, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 21, 2024 •
edited

Proposed changes

Ensure documentation is accurate for helm version

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners March 21, 2024 09:50
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Mar 21, 2024
@danielnginx danielnginx mentioned this pull request Mar 21, 2024
Merged
6 tasks
@pdabelf5 pdabelf5 merged commit 0698b83 into main Mar 21, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the docs/fix-helm-version branch March 21, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pdabelf5 @ADubhlaoich @j1m-ryan @jjngx