Don't reload when use-cluster-ip endpoints update, and change the ingress use-cluster-ip implementation to use the cluster ip instead of the fqdn
#5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fqdn, don't relaod when use-cluster-ip endpoints update
github-actions
bot
added
bug
vepatel
reviewed
Apr 2, 2024
jjngx
approved these changes
Apr 2, 2024
oseoin
approved these changes
Apr 3, 2024
vepatel
approved these changes
Apr 4, 2024
j1m-ryan
added a commit
that referenced
this pull request
Apr 29, 2024
…ngress `use-cluster-ip` implementation to use the cluster ip instead of the fqdn (#5318) * change use-cluster-ip implementation to use the cluster ip instead of fqdn, don't relaod when use-cluster-ip endpoints update * Update controller.go * Fix vs use cluster ip test * move assert function to custom_assertions.py
6 tasks
j1m-ryan
added a commit
that referenced
this pull request
Apr 29, 2024
Don't reload when `use-cluster-ip` endpoints update, and change the ingress `use-cluster-ip` implementation to use the cluster ip instead of the fqdn (#5318) * change use-cluster-ip implementation to use the cluster ip instead of fqdn, don't relaod when use-cluster-ip endpoints update * Update controller.go * Fix vs use cluster ip test * move assert function to custom_assertions.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4945
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.