Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ap-waf flag in error message #5350

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix ap-waf flag in error message #5350

merged 1 commit into from
Apr 4, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Apr 4, 2024 •
edited

Proposed changes

  • Fix the flag specified with WAF error msg

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner April 4, 2024 14:19
@github-actions github-actions bot added the bug An issue reporting a potential bug label Apr 4, 2024
@vepatel vepatel requested a review from jjngx April 4, 2024 14:24
@vepatel vepatel merged commit 6d771f3 into main Apr 4, 2024
80 checks passed
@vepatel vepatel deleted the fix/appprotect-error-msg branch April 4, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vepatel @j1m-ryan @jjngx