Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect count of secrets #5404

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Collect count of secrets #5404

merged 8 commits into from
Apr 16, 2024

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Apr 16, 2024

Proposed changes

This change updates the telemetry collector to count the number of Secret resources managed by the Ingress Controller.
This change makes updates to our local Secret store to allow access to the secret reference map. This ensures we only count secrets that are watched and managed by NIC (i.e. it will exclude secrets that we explicitly ignore and secrets that are not in a watched namespace)

Additional changes

  • Updated comments in values.yaml
  • Renamed variables and structs in main.go and update some comments

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Apr 16, 2024
@shaun-nx shaun-nx marked this pull request as ready for review April 16, 2024 10:59
@shaun-nx shaun-nx requested review from a team as code owners April 16, 2024 10:59
@shaun-nx shaun-nx linked an issue Apr 16, 2024 that may be closed by this pull request
@shaun-nx shaun-nx changed the title Telemetry/secret counts Collect count of secrets Apr 16, 2024
@shaun-nx shaun-nx added the go Pull requests that update Go code label Apr 16, 2024
@shaun-nx shaun-nx enabled auto-merge (squash) April 16, 2024 12:22
@shaun-nx shaun-nx merged commit 3ab4514 into main Apr 16, 2024
49 checks passed
@shaun-nx shaun-nx deleted the telemetry/secret-counts branch April 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect count of Secrets
3 participants