Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add telemetry data - ingresses #5406

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Add telemetry data - ingresses #5406

merged 4 commits into from
Apr 17, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Apr 16, 2024

Proposed changes

This PR adds support for collecting number of ingresses for telemetry data.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner April 16, 2024 14:30
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Apr 16, 2024
@jjngx jjngx added this to the v3.6.0 milestone Apr 16, 2024
@jjngx jjngx linked an issue Apr 16, 2024 that may be closed by this pull request
Collect count of Ingresses #5138
Closed
@jjngx jjngx changed the title Feat/telemetry ingresses Add telemetry data - ingresses Apr 16, 2024
@shaun-nx
Copy link
Contributor

The product telemetry docs here need to be updated to include Ingress

@jjngx jjngx requested a review from a team as a code owner April 17, 2024 09:06
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 17, 2024
@jjngx
Copy link
Contributor Author

jjngx commented Apr 17, 2024

The product telemetry docs here need to be updated to include Ingress

done

@jjngx jjngx merged commit 68f523b into main Apr 17, 2024
78 checks passed
@jjngx jjngx deleted the feat/telemetry-ingresses branch April 17, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
NGINX Ingress Controller
Archived in project
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Collect count of Ingresses
4 participants
@jjngx @shaun-nx @j1m-ryan @vepatel