Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set reporting endpoint in makefile #5411

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Set reporting endpoint in makefile #5411

merged 3 commits into from
Apr 17, 2024

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Apr 17, 2024

Proposed changes

Allows the reporting endpoint to be set asa build argument.
This is useful in development scenarios where we don't want to send data to the production endpoint

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner April 17, 2024 10:01
@github-actions github-actions bot added go Pull requests that update Go code chore Pull requests for routine tasks labels Apr 17, 2024
@vepatel vepatel requested a review from pdabelf5 April 17, 2024 10:10
@shaun-nx shaun-nx merged commit 9655776 into main Apr 17, 2024
78 checks passed
@shaun-nx shaun-nx deleted the chore/telem-endpoint branch April 17, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants