Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named ports in ingresses which use-cluster-ip #5456

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Fixes #4970

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner April 26, 2024 12:36
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Apr 26, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) April 26, 2024 16:20
@j1m-ryan j1m-ryan merged commit 3b7340b into main Apr 26, 2024
50 checks passed
@j1m-ryan j1m-ryan deleted the fix/named-port-use-cluster-ip branch April 26, 2024 16:43
j1m-ryan added a commit that referenced this pull request Apr 29, 2024
…r-ip (#5456) (#5470)

Add support for named ports in ingresses which use-cluster-ip (#5456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

NIC Fails to Resolve Named Ports with nginx.org/use-cluster-ip Annotation
3 participants