Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update codegen #5462

Merged
merged 1 commit into from
Apr 29, 2024
Merged

update codegen #5462

merged 1 commit into from
Apr 29, 2024

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Apr 29, 2024 •
edited

Proposed changes

Manually updating codegen since make verify-codegen fails locally but not detected by pipeline. See #5446

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the go Pull requests that update Go code label Apr 29, 2024
@haywoodsh
update codegen
02fb960 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh marked this pull request as ready for review April 29, 2024 11:43
@haywoodsh haywoodsh requested a review from a team as a code owner April 29, 2024 11:43
@haywoodsh haywoodsh added the chore Pull requests for routine tasks label Apr 29, 2024
@haywoodsh haywoodsh merged commit 7d505b7 into main Apr 29, 2024
78 checks passed
@haywoodsh haywoodsh deleted the chore/update-codegen branch April 29, 2024 13:33
pdabelf5 pushed a commit that referenced this pull request May 7, 2024
@haywoodsh @pdabelf5
update codegen (#5462)
dca7181 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks go Pull requests that update Go code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haywoodsh @oseoin @vepatel @jjngx