Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Granular Policy count for telemetry #5489

Merged
merged 8 commits into from
May 3, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented May 2, 2024

Proposed changes

This changes existing PolicyCount for telemetry to add individual counts for each policy eg. rateLimit, accessControl etc

logs:

I0502 10:02:20.594580       1 collector.go:142] Telemetry data collected: {Data:{ProjectName:NIC ProjectVersion:3.6.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:707783d6-be8b-4ce0-ad22-3545281b9bb9 ClusterVersion:v1.28.3 ClusterPlatform:other InstallationID:cc55e25c-beea-45fd-af68-b0dd501a5d5a ClusterNodeCount:1} NICResourceCounts:{VirtualServers:2 VirtualServerRoutes:0 TransportServers:0 Replicas:1 Secrets:5 Services:3 Ingresses:0 IngressClasses:1 AccessControlPolicies:0 RateLimitPolicies:2 JWTAuthPolicies:1 BasicAuthPolicies:1 IngressMTLSPolicies:1 EgressMTLSPolicies:0 OIDCPolicies:0 WAFPolicies:0 GlobalConfiguration:false}}

Resolves: #5453

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners May 2, 2024 08:59
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code labels May 2, 2024
internal/telemetry/cluster.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlexFenlon AlexFenlon merged commit a42bf4f into main May 3, 2024
78 checks passed
@AlexFenlon AlexFenlon deleted the feat/telemetry-granular-policy-count branch May 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Granularise Policy Counts
5 participants