Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add local helm schema validation #5493

Merged
merged 4 commits into from
May 3, 2024
Merged

add local helm schema validation #5493

merged 4 commits into from
May 3, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented May 2, 2024 •
edited

Proposed changes

Don't call out to remote schema to validate helm chart

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner May 2, 2024 15:35
@github-actions github-actions bot added chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart labels May 2, 2024
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label May 2, 2024
@pdabelf5 pdabelf5 merged commit 533ef48 into main May 3, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the schema-validation branch May 3, 2024 11:19
@danielnginx danielnginx mentioned this pull request May 7, 2024
Closed
@pdabelf5 pdabelf5 linked an issue May 7, 2024 that may be closed by this pull request
unable to install in an air-gapped environment #5374
Closed
@pdabelf5 pdabelf5 added this to the v3.6.0 milestone May 7, 2024
oseoin added a commit that referenced this pull request May 9, 2024
@oseoin
Revert "add local helm schema validation (#5493)"
3ef8a94 
This reverts commit 533ef48.
@oseoin oseoin mentioned this pull request May 9, 2024
Merged
oseoin added a commit that referenced this pull request May 9, 2024
@oseoin
Revert "add local helm schema validation" (#5528)
1e8e309 
Revert "add local helm schema validation (#5493)"

This reverts commit 533ef48.
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@oseoin @ssrahul96
Revert "add local helm schema validation" (nginxinc#5528)
e57e52e 
Revert "add local helm schema validation (nginxinc#5493)"

This reverts commit 533ef48.
@j1m-ryan j1m-ryan mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

unable to install in an air-gapped environment
5 participants
@pdabelf5 @oseoin @j1m-ryan @vepatel @jjngx