Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable logging in tests #5499

Merged
merged 10 commits into from
May 3, 2024
Merged

enable logging in tests #5499

merged 10 commits into from
May 3, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 3, 2024

Proposed changes

  • Enable logging in tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner May 3, 2024 13:42
@github-actions github-actions bot added python Pull requests that update Python code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks tests Pull requests that update tests labels May 3, 2024
@vepatel vepatel enabled auto-merge (squash) May 3, 2024 13:53
@vepatel vepatel merged commit 30a4824 into main May 3, 2024
50 checks passed
@vepatel vepatel deleted the tests/enable-logging branch May 3, 2024 14:05
oseoin added a commit that referenced this pull request May 14, 2024
oseoin added a commit that referenced this pull request May 14, 2024
Revert "enable logging in tests (#5499)"

This reverts commit 30a4824.
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
Revert "enable logging in tests (nginxinc#5499)"

This reverts commit 30a4824.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code python Pull requests that update Python code tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants