Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "enable logging in tests" #5543

Merged
merged 1 commit into from
May 14, 2024
Merged

Revert "enable logging in tests" #5543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def pytest_runtest_makereport(item) -> None:
rep = outcome.get_result()

# we only look at actual failing test calls, not setup/teardown
if rep.when == "call" and item.config.getoption("--show-ic-logs") == "yes":
if rep.when == "call" and rep.failed and item.config.getoption("--show-ic-logs") == "yes":
pod_namespace = item.funcargs["ingress_controller_prerequisites"].namespace
pod_name = get_first_pod_name(item.funcargs["kube_apis"].v1, pod_namespace)
print("\n===================== IC Logs Start =====================")
Expand Down
Loading