Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect errors showing in Telemetry #5561

Merged
merged 5 commits into from
May 16, 2024
Merged

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

Changed incorrect errors displaying in Telemetry when tests ran, these "error" logs were non breaking and are better off as just info logs as we do not want to think the user is seeing an error when in fact it is just debug information. Added logs to the rest of telemetry additions too to keep it consistant.

These were the errors that showed but now is converted to info logs:

E0503 13:45:22.124934   63999 collector.go:197] Error collecting telemetry data: Replicas: pods "" not found
E0503 13:45:22.124946   63999 collector.go:202] Error collecting telemetry data: InstallationID: error generating InstallationID: pods "" not found
E0503 13:45:22.124949   63999 collector.go:207] Error collecting telemetry data: Secrets: nil secret store
E0503 13:45:22.125640   63999 collector.go:177] Error collecting telemetry data: ClusterID: namespaces "kube-system" not found

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner May 16, 2024 13:48
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels May 16, 2024
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jjngx jjngx merged commit 15b0298 into main May 16, 2024
78 checks passed
@jjngx jjngx deleted the fix/telemetry-error-info-logs branch May 16, 2024 16:44
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants