-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Granular Ingress Counts to Telemetry #5608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ remove non-working tests
Co-authored-by: Shaun <s.odonovan@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
…emetry-granular-ingress-counts # Conflicts: # internal/telemetry/collector_test.go
jjngx
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
ADubhlaoich
approved these changes
May 27, 2024
shaun-nx
approved these changes
May 28, 2024
ssrahul96
pushed a commit
to ssrahul96/kubernetes-ingress
that referenced
this pull request
Jun 20, 2024
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change granulaises the counting of ingresses so instead of a total number, this adds Regular Ingress, Master Ingress and Minion Ingress counts to Telemetry.
I have added go tests for this functionality.
Here is a snippet of the log where I deployed a mergeable ingress with 1 master and 2 minions:
Resolves: #5454
Checklist
Before creating a PR, run through this checklist and mark each as complete.