Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] remove cert-gen script #5632

Merged
merged 2 commits into from
May 28, 2024
Merged

[cherry-pick] remove cert-gen script #5632

merged 2 commits into from
May 28, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 28, 2024 •
edited

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners May 28, 2024 11:10
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels May 28, 2024
@vepatel vepatel enabled auto-merge (squash) May 28, 2024 11:39
@vepatel vepatel changed the title remove cert-gen script [cherry-pick] remove cert-gen script May 28, 2024
@vepatel vepatel merged commit c81bd50 into release-3.5 May 28, 2024
45 checks passed
@vepatel vepatel deleted the chore/remove-cert-gen branch May 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vepatel @ADubhlaoich @AlexFenlon @jjngx @pdabelf5