Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable external service args #5736

Merged
merged 2 commits into from
Jun 12, 2024
Merged

enable external service args #5736

merged 2 commits into from
Jun 12, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 12, 2024 •
edited

Proposed changes

  • Required for ratelimit-scaling to work with manifest deployments and is already enabled by default in helm

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner June 12, 2024 12:48
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jun 12, 2024
@vepatel vepatel merged commit 2e99813 into main Jun 12, 2024
81 checks passed
@vepatel vepatel deleted the feat/enable-service-status branch June 12, 2024 14:06
pdabelf5 pushed a commit that referenced this pull request Jun 17, 2024
@vepatel @pdabelf5
enable external service args (#5736)
bd93b6b
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@vepatel @ssrahul96
enable external service args (nginxinc#5736)
41f5868
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vepatel @oseoin @j1m-ryan @AlexFenlon @pdabelf5