Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount config and deployments dirs to smoke containers #5740

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Mount config and deployments dirs to smoke containers #5740

merged 10 commits into from
Jun 13, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jun 13, 2024 •
edited

Proposed changes

Currently the config and deployments directories are not mounted to smoke test containers, which means that changes to CRDs are not picked up.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin marked this pull request as ready for review June 13, 2024 09:18
@oseoin oseoin requested a review from a team as a code owner June 13, 2024 09:18
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 13, 2024
@oseoin oseoin changed the title mount config and deployments dirs to smoke containers Mount config and deployments dirs to smoke containers Jun 13, 2024
@github-actions github-actions bot added the tests Pull requests that update tests label Jun 13, 2024
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 13, 2024
@github-actions github-actions bot removed the go Pull requests that update Go code label Jun 13, 2024
@github-actions github-actions bot removed github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 13, 2024
@github-actions github-actions bot added go Pull requests that update Go code github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 13, 2024
@oseoin oseoin enabled auto-merge (squash) June 13, 2024 13:47
@oseoin oseoin merged commit f8fa93d into main Jun 13, 2024
54 checks passed
@oseoin oseoin deleted the remove-hardcoded-config-dir branch June 13, 2024 14:07
pdabelf5 pushed a commit that referenced this pull request Jun 17, 2024
@oseoin @pdabelf5
Mount config and deployments dirs to smoke containers (#5740)
bf146cd
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@oseoin @ssrahul96
Mount config and deployments dirs to smoke containers (nginxinc#5740)
898bd86
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code go Pull requests that update Go code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oseoin @j1m-ryan @vepatel @pdabelf5