Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace skopeo action with skopeo image #5760

Merged
merged 5 commits into from
Jun 14, 2024
Merged

replace skopeo action with skopeo image #5760

merged 5 commits into from
Jun 14, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 14, 2024 •
edited

Proposed changes

  • Replace skopeo action with pre-built skopeo container image
  • Add tags for publishing waf v5 images
  • Add missing script for building binary release bundles
  • Fix tag exists logic

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner June 14, 2024 13:00
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks tests Pull requests that update tests labels Jun 14, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) June 14, 2024 16:27
@pdabelf5 pdabelf5 merged commit 8752533 into main Jun 14, 2024
84 of 85 checks passed
@pdabelf5 pdabelf5 deleted the tidy-rel-workflow branch June 14, 2024 16:32
pdabelf5 added a commit that referenced this pull request Jun 17, 2024
@pdabelf5
replace skopeo action with skopeo image (#5760)
f5618ed
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@pdabelf5 @ssrahul96
replace skopeo action with skopeo image (nginxinc#5760)
282a2da
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code github_actions Pull requests that update Github_actions code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pdabelf5 @oseoin @jjngx