Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update values schema from 1.29 to 1.30 #5772

Merged
merged 4 commits into from
Jun 18, 2024
Merged

update values schema from 1.29 to 1.30 #5772

merged 4 commits into from
Jun 18, 2024

Conversation

j1m-ryan
Copy link
Member

@j1m-ryan j1m-ryan commented Jun 18, 2024 •
edited

Proposed changes

#5738
Update 1.29.0 to 1.30.0 in values schema
Update 2.7 to 3.7 for deprecation of includeyear
Update test referenceing 1.29.2 to 1.30.0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested review from a team as code owners June 18, 2024 10:07
@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Jun 18, 2024
@github-actions github-actions bot removed the documentation Pull requests/issues for documentation label Jun 18, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) June 18, 2024 13:59
@j1m-ryan j1m-ryan merged commit 7a278b9 into main Jun 18, 2024
54 checks passed
@j1m-ryan j1m-ryan deleted the chore/update-values-schema branch June 18, 2024 15:39
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@j1m-ryan @ssrahul96
update values schema from 1.29 to 1.30 (nginxinc#5772)
6d06c26 
* update from 1.29 to 1.30

* remove flag
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@j1m-ryan @vepatel @AlexFenlon @shaun-nx @pdabelf5