-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change log level, to Info and above, before calling prometheus exporter functions #5786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdabelf5
approved these changes
Jun 20, 2024
jjngx
approved these changes
Jun 20, 2024
nginx-bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
…er functions (#5786) * wrap logger * tidy go mod * remove level library import * make library indirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An issue reporting a potential bug
go
Pull requests that update Go code
needs cherry pick
Cherry pick this PR into a release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Tests
Fixes #5607
![image](https://private-user-images.githubusercontent.com/20595836/341135427-17d98f3e-fcfe-47b1-a496-cd04a5f49c31.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NTE1NTYsIm5iZiI6MTcyNDQ1MTI1NiwicGF0aCI6Ii8yMDU5NTgzNi8zNDExMzU0MjctMTdkOThmM2UtZmNmZS00N2IxLWE0OTYtY2QwNGE1ZjQ5YzMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIzVDIyMTQxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0ZTQ2MDdkYmExZWRkMTVlOTY0NzIzMTgwYWRlY2Q5OGVlYjk3YmZmMGJmNjAyMmFiNTRmODAwMDZjMTBkMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cdxfR2f1GGrrpPvlrfhymw-0L3bIq1KFfQO3XIuumaE)
![image](https://private-user-images.githubusercontent.com/20595836/341136255-5b35e339-03af-4146-a8f6-af1566ed05fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NTE1NTYsIm5iZiI6MTcyNDQ1MTI1NiwicGF0aCI6Ii8yMDU5NTgzNi8zNDExMzYyNTUtNWIzNWUzMzktMDNhZi00MTQ2LWE4ZjYtYWYxNTY2ZWQwNWZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIzVDIyMTQxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM4NTFkNGM3OGQxNTMzZjRmNDNlZjlmMmZhZDNhY2Y2NDBkMWZhYmY0MWNkYWUxZmI3YmUxOTk5NjJiYTE1YmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9AfQnAv6N1swaemXrS1ogxCqWp05OxsxsOHhmu0qBFo)
Add these logs to the collect function (temporarily) in my local NGINX Prometheus Exporter repo
Point my go.mod towards that local repo
Add the change that sets the log level to Info
Hit the
:9113/metrics
endpointLook at the logs
No sign of the debug log
Checklist
Before creating a PR, run through this checklist and mark each as complete.