Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip upload test results on skipped tests #5827

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Skip upload test results on skipped tests #5827

merged 1 commit into from
Jun 24, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jun 24, 2024

Proposed changes

Fix for: https://github.com/nginxinc/kubernetes-ingress/actions/runs/9642613820/job/26590954663

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested a review from a team as a code owner June 24, 2024 09:12
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 24, 2024
@oseoin oseoin enabled auto-merge (squash) June 24, 2024 09:14
@oseoin oseoin merged commit 379e30b into main Jun 24, 2024
80 checks passed
@oseoin oseoin deleted the fix-test-upload branch June 24, 2024 09:41
@oseoin oseoin mentioned this pull request Jun 24, 2024
Merged
6 tasks
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@oseoin @AlexFenlon
Skip upload test results on skipped tests (#5827)
c5a80e9
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oseoin @j1m-ryan @vepatel @AlexFenlon @jjngx @shaun-nx