Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actionlint pre commit plugin #5839

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add actionlint pre commit plugin #5839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcbb80e
run the rep-commit actionlint plugin locally
pdabelf5 Jun 24, 2024
df9efcd
tidy excessive permissions
pdabelf5 Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build-oss.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ jobs:
runs-on: ubuntu-22.04
permissions:
contents: read # for docker/build-push-action to read repo content
security-events: write # for github/codeql-action/upload-sarif to upload SARIF results
id-token: write # for OIDC login to GCR
packages: write # for docker/build-push-action to push to GHCR
pull-requests: write # for scout report
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ jobs:
permissions:
contents: read
actions: read
security-events: write
id-token: write
packages: write
pull-requests: write # for scout report
Expand All @@ -331,7 +330,6 @@ jobs:
full-build: ${{ inputs.force && inputs.force || false }}
permissions:
contents: read
security-events: write
id-token: write
pull-requests: write # for scout report
secrets: inherit
Expand All @@ -356,8 +354,7 @@ jobs:
full-build: ${{ inputs.force && inputs.force || false }}
permissions:
contents: read
security-events: write
id-token: write
id-token: write # gcr login
pull-requests: write # for scout report
secrets: inherit

Expand Down
12 changes: 12 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,17 @@ repos:
hooks:
- id: markdownlint-cli2

- repo: https://github.com/rhysd/actionlint
rev: v1.7.1
hooks:
- id: actionlint
name: Lint GitHub Actions workflow files
description: Runs actionlint to lint GitHub Actions workflow files
language: golang
types: ["yaml"]
files: ^\.github/workflows/
entry: actionlint
args: ["-shellcheck",""]

ci:
skip: [golang-diff, golangci-lint, check-jsonschema, markdownlint-cli2]