Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminate milestone api call #5864

Merged
merged 2 commits into from
Jun 26, 2024
Merged

terminate milestone api call #5864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a916e
terminate milestone api call correctly
pdabelf5 Jun 26, 2024
01b626f
authenticate to publish to AWS marketplace
pdabelf5 Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,14 @@ jobs:
with:
ref: ${{ inputs.release_branch }}

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
with:
aws-region: us-east-1
role-to-assume: ${{ secrets.AWS_ROLE_MARKETPLACE }}

- name: Publish to AWS Marketplace
uses: nginxinc/aws-marketplace-publish@be512a7ae9666098bc4429a1afa27a11be6a3995 # v1.0.3
continue-on-error: true
with:
version: ${{ inputs.nic_version }}
product-id: ${{ secrets[matrix.product_id] }}
Expand Down Expand Up @@ -423,7 +428,7 @@ jobs:
'.[] | select(.title == $version) | .number')
if ! ${{ inputs.dry_run }}; then
gh api --method PATCH -H "Accept: application/vnd.github.v3+json" \
/repos/${{ github.repository }}/milestones/${milestone_number} \
/repos/${{ github.repository }}/milestones/${milestone_number};
else
echo "Skipping closing Github Release milestone, DRY_RUN"
fi
Expand Down