Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove fips from tests, image patching & release #5912

Merged
merged 1 commit into from
Jul 2, 2024
Merged

remove fips from tests, image patching & release #5912

merged 1 commit into from
Jul 2, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jul 2, 2024 •
edited
Loading

Proposed changes

openssl fips support is currently broken on alpine 3.17 & 3.19

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner July 2, 2024 08:57
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jul 2, 2024
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Jul 2, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) July 2, 2024 09:10
@pdabelf5 pdabelf5 changed the title move fips from tests, image patching & release remove fips from tests, image patching & release Jul 2, 2024
@pdabelf5 pdabelf5 merged commit 221bb86 into main Jul 2, 2024
80 checks passed
@pdabelf5 pdabelf5 deleted the disable-fips branch July 2, 2024 09:28
@shaun-nx shaun-nx mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pdabelf5 @oseoin @j1m-ryan @vepatel @AlexFenlon @jjngx