Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scc and update deployment #5934

Merged
merged 5 commits into from
Jul 3, 2024
Merged

add scc and update deployment #5934

merged 5 commits into from
Jul 3, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jul 3, 2024 •
edited

Proposed changes

  • Update example and docs for usage reporting

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners July 3, 2024 09:28
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Jul 3, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 3, 2024
ADubhlaoich
ADubhlaoich approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: one edit suggestion to clear up the grammar of the openshift note and add a link so the user doesn't have to go manually find the example YAML.

docs/content/usage-reporting.md Outdated Show resolved Hide resolved
@vepatel vepatel enabled auto-merge (squash) July 3, 2024 10:48
@vepatel vepatel merged commit 63df306 into main Jul 3, 2024
51 checks passed
@vepatel vepatel deleted the chore/update-cluster-connector-docs-ex branch July 3, 2024 10:57
nginx-bot pushed a commit that referenced this pull request Jul 3, 2024
@vepatel @web-flow
add scc and update deployment (#5934)
d72b557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vepatel @ADubhlaoich @haywoodsh @jjngx @shaun-nx