Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dos ubi image to v9 #6207

Merged
merged 10 commits into from
Aug 20, 2024
Merged

update dos ubi image to v9 #6207

merged 10 commits into from
Aug 20, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 15, 2024

Proposed changes

  • update App Protect DoS & WAF/DoS ubi image to ubi9
  • build ubi8 WAF & WAFv5 images & add ubi8 suffix (we are not releasing these images)
  • remove unused ubi-image-nap-dos-v5-plus make target
  • make ubi9 waf/dos image builds consume the nginx-plus image

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 15, 2024 11:15
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Aug 15, 2024
@pdabelf5 pdabelf5 linked an issue Aug 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.86%. Comparing base (491e68e) to head (092797b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6207      +/-   ##
==========================================
+ Coverage   45.58%   45.86%   +0.27%     
==========================================
  Files         142      142              
  Lines       18961    18961              
==========================================
+ Hits         8644     8696      +52     
+ Misses       9868     9818      -50     
+ Partials      449      447       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) August 20, 2024 14:40
@pdabelf5 pdabelf5 merged commit fdc7172 into main Aug 20, 2024
76 checks passed
@pdabelf5 pdabelf5 deleted the waf-dos-base-image branch August 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code github_actions Pull requests that update Github_actions code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Move DoS related images from UBI8 to UBI9
3 participants