Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor App Protect DoS controller #6212

Merged
merged 2 commits into from
Aug 20, 2024
Merged

refactor App Protect DoS controller #6212

merged 2 commits into from
Aug 20, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 15, 2024

Proposed changes

This change moves the App Protect DoS controller code to it's own file to help reduce the complexity of controller.go.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 15, 2024 15:29
@github-actions github-actions bot added go Pull requests that update Go code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Aug 15, 2024
@pdabelf5 pdabelf5 force-pushed the controller-dos-refactor branch 2 times, most recently from 3af03f6 to 162f2ea Compare August 15, 2024 15:31
@github-actions github-actions bot removed github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 201 lines in your changes missing coverage. Please review.

Project coverage is 45.86%. Comparing base (b32eae8) to head (ed54c03).
Report is 5 commits behind head on main.

Files Patch % Lines
internal/k8s/appprotect_dos.go 0.00% 201 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6212   +/-   ##
=======================================
  Coverage   45.86%   45.86%           
=======================================
  Files         142      143    +1     
  Lines       18961    18960    -1     
=======================================
  Hits         8696     8696           
+ Misses       9818     9817    -1     
  Partials      447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Aug 20, 2024
@github-actions github-actions bot removed github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Aug 20, 2024
@pdabelf5 pdabelf5 merged commit c16a9b3 into main Aug 20, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the controller-dos-refactor branch August 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants