Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when creating VirtualServer #6232

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Aug 18, 2024

Closes #6231

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hafe hafe requested a review from a team as a code owner August 18, 2024 16:22
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 18, 2024
Copy link
Member

@j1m-ryan j1m-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hafe, lgtm!

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.91%. Comparing base (c34df51) to head (ffab4a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6232      +/-   ##
==========================================
+ Coverage   45.86%   45.91%   +0.05%     
==========================================
  Files         143      143              
  Lines       18960    18964       +4     
==========================================
+ Hits         8696     8708      +12     
+ Misses       9817     9812       -5     
+ Partials      447      444       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan merged commit e753ec4 into nginxinc:main Aug 22, 2024
127 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Panic when creating VirtualServer
4 participants