Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_conns support for nginx plus #631

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Add max_conns support for nginx plus #631

merged 2 commits into from
Jul 24, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Extends upon #614 with support for nginx plus. Using the nginx plus api where possible.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jul 23, 2019
@Dean-Coakley Dean-Coakley self-assigned this Jul 23, 2019
pleshakov
pleshakov reviewed Jul 23, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley looks good! However, the approval is pending upon a successful CI build.

LorcanMcVeigh
LorcanMcVeigh approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Dean-Coakley Dean-Coakley merged commit abd6591 into master Jul 24, 2019
@Dean-Coakley Dean-Coakley deleted the feature/max-conns-plus-annot branch July 24, 2019 14:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @pleshakov @Rulox @LorcanMcVeigh